Bug 99713

Summary: MediaStream API: Do some cleanup in the chromium WebKit API
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit APIAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch none

Tommy Widenflycht
Reported 2012-10-18 06:15:43 PDT
1) Remove the deprecated version of WebMediaStreamDescriptor::initialize 2) Remove a deprecated constant from WebPeerConnection00HandlerClient 3) Make the two constructSDP functions in WebMediaStreamCenter optional to override. This is part of the preparation to remove PeerConnection00.
Attachments
Patch (4.98 KB, patch)
2012-10-18 06:26 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-10-18 06:26:42 PDT
Created attachment 169403 [details] Patch
WebKit Review Bot
Comment 2 2012-10-18 06:30:03 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Tommy Widenflycht
Comment 3 2012-10-18 06:32:18 PDT
Turns out point two could not yet be removed.
Adam Barth
Comment 4 2012-10-18 14:54:03 PDT
Can we remove webkitPeerConnection00 ?
WebKit Review Bot
Comment 5 2012-10-18 15:08:38 PDT
Comment on attachment 169403 [details] Patch Clearing flags on attachment: 169403 Committed r131814: <http://trac.webkit.org/changeset/131814>
WebKit Review Bot
Comment 6 2012-10-18 15:08:41 PDT
All reviewed patches have been landed. Closing bug.
Tommy Widenflycht
Comment 7 2012-10-19 00:33:22 PDT
(In reply to comment #4) > Can we remove webkitPeerConnection00 ? Soon, very soon. It won't be in M24 stable for sure.
Note You need to log in before you can comment on or make changes to this bug.