Bug 99687
| Summary: | Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp misuses PLATFORM(MAC) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Huddleston Sequoia <jeremyhu> |
| Component: | Web Inspector (Deprecated) | Assignee: | Jeremy Huddleston Sequoia <jeremyhu> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | apavlov, burg, joepeck, keishi, loislo, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jeremy Huddleston Sequoia
Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp returns "mac" for SValue JSInspectorFrontendHost::platform(ExecState* execState), but it should return "darwin" for OS(DARWIN) to be consistent. Similarly, JSInspectorFrontendHost::port should probably return "appkit" or "uikit" for PLATFORM(MAC_OS_X) or PLATFORM(IOS).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Timothy Hatcher
Feel free to change. You will need to fix up some js files in WebCore/inspector/front-end too that use "mac".
Jeremy Huddleston Sequoia
Ok, thanks I will. Feel free to assign this to me as I don't have that level of bugzilla access.