Bug 99653

Summary: [V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric, haraken, japhet, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-10-17 16:22:42 PDT
[V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
Attachments
Patch (1.72 KB, patch)
2012-10-17 16:22 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-10-17 16:22:59 PDT
Created attachment 169292 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-17 16:28:21 PDT
Comment on attachment 169292 [details] Patch Ha!
WebKit Review Bot
Comment 3 2012-10-17 17:04:02 PDT
Comment on attachment 169292 [details] Patch Clearing flags on attachment: 169292 Committed r131673: <http://trac.webkit.org/changeset/131673>
WebKit Review Bot
Comment 4 2012-10-17 17:04:06 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2012-10-17 22:50:50 PDT
bindings-generation-tests are failing after this patch. They probably need to be rebaselined: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/7350/steps/bindings-generation-tests/logs/stdio
Kentaro Hara
Comment 6 2012-10-17 22:56:16 PDT
(In reply to comment #5) > bindings-generation-tests are failing after this patch. They probably need to be rebaselined: > http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/7350/steps/bindings-generation-tests/logs/stdio Fixed in r131706. Sorry for the trouble.
Adam Barth
Comment 7 2012-10-17 23:08:22 PDT
Thanks Kentaro. It's me who should be apologizing.
Roger Fong
Comment 8 2012-10-18 06:17:59 PDT
Windows is still failing. Are there Windows specific results for the binding tests?
Roger Fong
Comment 9 2012-10-18 12:00:59 PDT
(In reply to comment #8) > Windows is still failing. Are there Windows specific results for the binding tests? http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29044 I'll try just rebaselining locally to see what happens.
Roger Fong
Comment 10 2012-10-18 14:29:02 PDT
(In reply to comment #9) > (In reply to comment #8) > > Windows is still failing. Are there Windows specific results for the binding tests? > > http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29044 > > I'll try just rebaselining locally to see what happens. Oops, that's from before the fix landing...my bad. Windows bots went down/stopped testing just before the fix it seems.
Note You need to log in before you can comment on or make changes to this bug.