| Summary: | Remove redundant sdk_build parameter. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Shashi Shekhar <shashishekhar> | ||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, peter, shashishekhar, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Shashi Shekhar
2012-10-17 15:53:38 PDT
Created attachment 169283 [details]
Patch
Created attachment 169284 [details]
Remove redundant sdk_build parameter.
Created attachment 169295 [details]
Remove redundant sdk_build parameter.
Looking at your Chromium change (http://src.chromium.org/viewvc/chrome?view=rev&revision=161127), this looks good to me. Adam, would you mind doing formal review? Shashi, do you also want to request this to be committed? If so, you can click on "details" next to your patch and select the question mark in the "commit-queue" box. Looking again, this does need a ChangeLog. Comment on attachment 169295 [details]
Remove redundant sdk_build parameter.
Yeah, we need a ChangeLog entry for this patch.
Created attachment 169302 [details]
Patch
Comment on attachment 169302 [details] Patch Thanks, Peter this patch is part of cleanup of our scripts, other instances for sdk_build in Chromium has been cleaned up. Patch you mentioned is correct: http://src.chromium.org/viewvc/chrome?view=rev&revision=161127 Currently this parameter is a no-op, we will remove it once WebKit is also updated. Done. (In reply to comment #6) > (From update of attachment 169295 [details]) > Yeah, we need a ChangeLog entry for this patch. Comment on attachment 169302 [details]
Patch
Thanks.
Comment on attachment 169302 [details] Patch Rejecting attachment 169302 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14397791 Comment on attachment 169302 [details] Patch Clearing flags on attachment: 169302 Committed r131681: <http://trac.webkit.org/changeset/131681> All reviewed patches have been landed. Closing bug. |