Bug 99622

Summary: Clean up Vector.h
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, dglazkov, japhet, kling, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch benjamin: review+

Anders Carlsson
Reported 2012-10-17 11:37:22 PDT
Clean up Vector.h
Attachments
Patch (20.62 KB, patch)
2012-10-17 11:43 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (23.06 KB, patch)
2012-10-17 14:32 PDT, Anders Carlsson 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-17 11:43:51 PDT
Created attachment 169227 [details] Patch
Benjamin Poulain
Comment 2 2012-10-17 11:57:08 PDT
Comment on attachment 169227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169227&action=review > Source/WTF/WTF.xcodeproj/project.pbxproj:1183 > + 1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */, The build section should be sorted alphabetically. The MemoryInstrumentationFooBar and WTFURL files are in the wrong place.
Andreas Kling
Comment 3 2012-10-17 12:03:04 PDT
Comment on attachment 169227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169227&action=review > Source/WTF/WTF.xcodeproj/project.pbxproj:1183 > + 1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */, The build section should be sorted alphabetically. The MemoryInstrumentationFooBar and WTFURL files are in the wrong place.
Anders Carlsson
Comment 4 2012-10-17 12:04:44 PDT
(In reply to comment #3) > (From update of attachment 169227 [details] [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169227&action=review > > > Source/WTF/WTF.xcodeproj/project.pbxproj:1183 > > + 1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */, > > The build section should be sorted alphabetically. The MemoryInstrumentationFooBar and WTFURL files are in the wrong place. They are sorted alphabetically in Xcode. Not sure why the project file is different.
Benjamin Poulain
Comment 5 2012-10-17 12:08:35 PDT
> They are sorted alphabetically in Xcode. Not sure why the project file is different. There are two sections. The file section, which is the one you see on the Project Navigator, and a build section, that is buried deep in the project settings (Project->Targets->Build phases->Copy Headers && Compile Source). It is just unfortunate the build section is not sorted by default.
Build Bot
Comment 6 2012-10-17 12:25:01 PDT
Comment on attachment 169227 [details] Patch Attachment 169227 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14391661
WebKit Review Bot
Comment 7 2012-10-17 12:32:05 PDT
Comment on attachment 169227 [details] Patch Attachment 169227 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14392680
Build Bot
Comment 8 2012-10-17 13:04:27 PDT
Comment on attachment 169227 [details] Patch Attachment 169227 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14390649
Gyuyoung Kim
Comment 9 2012-10-17 13:54:49 PDT
Comment on attachment 169227 [details] Patch Attachment 169227 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14424203
Peter Beverloo (cr-android ews)
Comment 10 2012-10-17 14:03:03 PDT
Comment on attachment 169227 [details] Patch Attachment 169227 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14412232
Anders Carlsson
Comment 11 2012-10-17 14:32:40 PDT
Created attachment 169263 [details] Patch
Benjamin Poulain
Comment 12 2012-10-17 14:37:45 PDT
Comment on attachment 169263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169263&action=review > Source/WTF/WTF.xcodeproj/project.pbxproj:1184 > F3FBC71E161AF7BF00BB4BD4 /* MemoryInstrumentationHashCountedSet.h in Headers */, > F3FBC720161AF7CD00BB4BD4 /* MemoryInstrumentationSequence.h in Headers */, > + 1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */, > ); Uh? :(
Anders Carlsson
Comment 13 2012-10-17 14:40:45 PDT
(In reply to comment #12) > (From update of attachment 169263 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169263&action=review > > > Source/WTF/WTF.xcodeproj/project.pbxproj:1184 > > F3FBC71E161AF7BF00BB4BD4 /* MemoryInstrumentationHashCountedSet.h in Headers */, > > F3FBC720161AF7CD00BB4BD4 /* MemoryInstrumentationSequence.h in Headers */, > > + 1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */, > > ); > > Uh? :( It's explained in the ChangeLog.
Anders Carlsson
Comment 14 2012-10-17 15:05:55 PDT
(In reply to comment #5) > > They are sorted alphabetically in Xcode. Not sure why the project file is different. > > There are two sections. > The file section, which is the one you see on the Project Navigator, and a build section, that is buried deep in the project settings (Project->Targets->Build phases->Copy Headers && Compile Source). > > It is just unfortunate the build section is not sorted by default. Ah. Makes sense. I went ahead and sorted all files in the project. I'll update the ChangeLog to reflect this.
Anders Carlsson
Comment 15 2012-10-17 15:51:11 PDT
Committed r131659: <http://trac.webkit.org/changeset/131659>
Note You need to log in before you can comment on or make changes to this bug.