Bug 99548

Summary: Live oversize copied blocks should count toward overall heap fragmentation
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Mark Hahnenberg
Reported 2012-10-16 23:31:07 PDT
The CopiedSpace uses overall heap fragmentation to determine whether or not it should do any copying. Currently it doesn't include live oversize CopiedBlocks in the calculation, but it should. We can also free any dead oversize CopiedBlocks while we're iterating over them, rather than iterating over them again at the end of the copying phase.
Attachments
Patch (5.87 KB, patch)
2012-10-18 15:07 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-10-18 15:07:13 PDT
Created attachment 169482 [details] Patch
WebKit Review Bot
Comment 2 2012-10-18 15:42:46 PDT
Comment on attachment 169482 [details] Patch Clearing flags on attachment: 169482 Committed r131818: <http://trac.webkit.org/changeset/131818>
WebKit Review Bot
Comment 3 2012-10-18 15:42:49 PDT
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 4 2012-10-18 16:20:07 PDT
Comment on attachment 169482 [details] Patch r=me
Note You need to log in before you can comment on or make changes to this bug.