Bug 9954

Summary: REGRESSION: document.dir should return empty string in <head>
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: FormsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P1 Keywords: Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch v1 darin: review+

David Kilzer (:ddkilzer)
Reported 2006-07-16 07:15:27 PDT
The patch for Bug 9911 caused a minor regression where document.dir should return an empty string in <head>.  This matches what production Safari 2.0.4 (419.3) does. Note that Bug 9947 covers the "real" fix to document.dir, which can't be set in <head> and which is currently linked to body.dir (unlike Firefox and MSIE).
Attachments
Patch v1 (4.36 KB, patch)
2006-07-16 08:29 PDT, David Kilzer (:ddkilzer) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-07-16 08:29:02 PDT
Created attachment 9493 [details] Patch v1 Changes document.dir to return an empty string instead of undef in <head>.
Darin Adler
Comment 2 2006-07-16 15:27:55 PDT
Comment on attachment 9493 [details] Patch v1 r=me
David Kilzer (:ddkilzer)
Comment 3 2006-07-16 21:15:17 PDT
Committed revision 15479.
David Kilzer (:ddkilzer)
Comment 4 2007-06-24 12:04:44 PDT
Mass removal of NeedsRadar keyword from my bugs that have already been RESOLVED.
Note You need to log in before you can comment on or make changes to this bug.