Bug 99539

Summary: Fix build warnings : -Wunused-parameter, -Wunused-variable
Product: WebKit Reporter: Byungwoo Lee <bw80.lee>
Component: WebCore Misc.Assignee: Byungwoo Lee <bw80.lee>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric, gyuyoung.kim, haraken, noam, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Byungwoo Lee 2012-10-16 22:21:44 PDT 
Fix build warnings about unused parameter or variable when WTF_USE_TILED_BACKING_STORE is enabled.
Comment 1 Byungwoo Lee 2012-10-16 22:41:07 PDT 
Created attachment 169091 [details]
Patch
Comment 2 Kentaro Hara 2012-10-17 00:39:09 PDT 
Comment on attachment 169091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169091&action=review

Let's rebase with the latest WebKit and make bots green.

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:76
> +    virtual bool canReuseWith(const IntSize& /* contentsSize */, Flags flags = 0)

You can write 'Flags = 0' and remove UNUSED_PARAM().

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:147
> +    virtual void beginPainting(PaintFlags flags = 0)

Ditto.

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:410
> +void TextureMapperLayer::flushCompositingStateSelf(GraphicsLayerTextureMapper* graphicsLayer, TextureMapper* /* textureMapper */)

Remove this argument instead of commenting out.
Comment 3 Byungwoo Lee 2012-10-17 02:27:16 PDT 
(In reply to comment #2)
> (From update of attachment 169091 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169091&action=review
> 
> Let's rebase with the latest WebKit and make bots green.
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapper.h:76
> > +    virtual bool canReuseWith(const IntSize& /* contentsSize */, Flags flags = 0)
> 
> You can write 'Flags = 0' and remove UNUSED_PARAM().
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapper.h:147
> > +    virtual void beginPainting(PaintFlags flags = 0)
> 
> Ditto.
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:410
> > +void TextureMapperLayer::flushCompositingStateSelf(GraphicsLayerTextureMapper* graphicsLayer, TextureMapper* /* textureMapper */)
> 
> Remove this argument instead of commenting out.

Thanks for the comment. I'll do those :)
Comment 4 Byungwoo Lee 2012-10-17 03:08:23 PDT 
Created attachment 169145 [details]
Patch
Comment 5 WebKit Review Bot 2012-10-17 10:15:19 PDT 
Comment on attachment 169145 [details]
Patch

Clearing flags on attachment: 169145

Committed r131617: <http://trac.webkit.org/changeset/131617>
Comment 6 WebKit Review Bot 2012-10-17 10:15:23 PDT 
All reviewed patches have been landed.  Closing bug.