Bug 99527

Summary: IndexedDB: Stub out chromium success handlers for integers and undefined values
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dgrogan, fishd, jamesr, jsbell, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alec Flett 2012-10-16 17:03:57 PDT 
IndexedDB: Stub out chromium success handlers for integers and undefined values
Comment 1 Alec Flett 2012-10-16 17:04:37 PDT 
Created attachment 169060 [details]
Patch
Comment 2 Alec Flett 2012-10-16 17:06:03 PDT 
jsbell/dgrogan - quick review? I'm adding:

onSuccess(int64_t) - for the result of count(), previously calling onSuccess(SerializedScriptValue::numberValue(count))

onSuccess() - anytime we were calling onSuccess(SerializedScriptValue::undefinedValue())

This stubs these out so I can land chromium, then I'll have a webkit patch to follow
Comment 3 WebKit Review Bot 2012-10-16 17:07:03 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Joshua Bell 2012-10-16 17:15:21 PDT 
Comment on attachment 169060 [details]
Patch

LGTM. We may want to sort the lines so onSuccess() comes first.
Comment 5 Alec Flett 2012-10-16 17:24:19 PDT 
abarth@ - r?
Comment 6 Adam Barth 2012-10-16 18:00:40 PDT 
Comment on attachment 169060 [details]
Patch

Ok.
Comment 7 WebKit Review Bot 2012-10-16 18:30:19 PDT 
Comment on attachment 169060 [details]
Patch

Clearing flags on attachment: 169060

Committed r131540: <http://trac.webkit.org/changeset/131540>
Comment 8 WebKit Review Bot 2012-10-16 18:30:23 PDT 
All reviewed patches have been landed.  Closing bug.