Bug 99497

Summary: [BlackBerry] calculateInRegionScrollableAreasForPoint should use a ReadOnly HitTest
Product: WebKit Reporter: Mike Lattanzio <mlattanzio>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mike Lattanzio
Reported 2012-10-16 13:42:01 PDT
void InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint(const WebCore::IntPoint& point) mistakenly passes a second parameter into m_webPage->m_mainFrame->eventHandler()->hitTestResultAtPoint that slows down its hit test by making it not ReadOnly. Since this happens on the hot path to event handling it is important to improve it.
Attachments
Patch (1.91 KB, patch)
2012-10-16 14:04 PDT, Mike Lattanzio 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Lattanzio
Comment 1 2012-10-16 14:04:38 PDT
Created attachment 169020 [details] Patch
Antonio Gomes
Comment 2 2012-10-16 14:56:59 PDT
Comment on attachment 169020 [details] Patch Doh! Someone changed the API and did not update our usage :/
WebKit Review Bot
Comment 3 2012-10-16 15:05:50 PDT
Comment on attachment 169020 [details] Patch Clearing flags on attachment: 169020 Committed r131513: <http://trac.webkit.org/changeset/131513>
WebKit Review Bot
Comment 4 2012-10-16 15:05:54 PDT
All reviewed patches have been landed. Closing bug.
Rob Buis
Comment 5 2012-10-17 07:12:39 PDT
Comment on attachment 169020 [details] Patch LGTM.
Note You need to log in before you can comment on or make changes to this bug.