Bug 99479

Summary: [EFL][WK2] Add factory methods for refcounted Ewk types
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99321    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-10-16 10:58:17 PDT
We should create factory methods for refcounted ewk types and get rid of private _new() functions. This makes the private API more C++ and promotes the use of smart pointers.
Attachments
Patch (34.06 KB, patch)
2012-10-16 11:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-16 11:34:28 PDT
Created attachment 168987 [details] Patch
Gyuyoung Kim
Comment 2 2012-10-16 19:17:32 PDT
Comment on attachment 168987 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-10-16 19:21:01 PDT
Comment on attachment 168987 [details] Patch Clearing flags on attachment: 168987 Committed r131546: <http://trac.webkit.org/changeset/131546>
WebKit Review Bot
Comment 4 2012-10-16 19:21:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.