Bug 99472

Summary: [EFL][WK2] Start using OwnPtr for non-ref counted ewk types
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2012-10-16 09:41:44 PDT
We should start using OwnPtr internally for non-ref counted Ewk types.
Attachments
Patch (38.05 KB, patch)
2012-10-16 10:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.08 KB, patch)
2012-10-16 21:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-16 10:40:26 PDT
Created attachment 168968 [details] Patch
Chris Dumez
Comment 2 2012-10-16 21:22:51 PDT
Created attachment 169082 [details] Patch Rebase on master.
Kenneth Rohde Christiansen
Comment 3 2012-10-17 00:15:00 PDT
Comment on attachment 169082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169082&action=review > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h:51 > typedef struct _Ewk_Cookie_Manager Ewk_Cookie_Manager; Why do we do these C style things?
Mikhail Pozdnyakov
Comment 4 2012-10-17 00:18:56 PDT
(In reply to comment #3) > (From update of attachment 169082 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169082&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h:51 > > typedef struct _Ewk_Cookie_Manager Ewk_Cookie_Manager; > > Why do we do these C style things? Think we can do the same as it's done in WK C API: typedef struct WKPageLoaderClient WKPageLoaderClient; That would let us to remove typedef from private header at all.
Mikhail Pozdnyakov
Comment 5 2012-10-17 00:20:06 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 169082 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=169082&action=review > > > > > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h:51 > > > typedef struct _Ewk_Cookie_Manager Ewk_Cookie_Manager; > > > > Why do we do these C style things? > > Think we can do the same as it's done in WK C API: > > typedef struct WKPageLoaderClient WKPageLoaderClient; > > That would let us to remove typedef from private header at all. I mean use typedef struct Ewk_Cookie_Manager Ewk_Cookie_Manager; in public header.
WebKit Review Bot
Comment 6 2012-10-17 00:28:48 PDT
Comment on attachment 169082 [details] Patch Clearing flags on attachment: 169082 Committed r131558: <http://trac.webkit.org/changeset/131558>
WebKit Review Bot
Comment 7 2012-10-17 00:28:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.