Bug 99357
| Summary: | Layout Test webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html is failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dana Jansens <danakj> |
| Component: | Tools / Tests | Assignee: | Chris Rogers <crogers> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | crogers |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dana Jansens
The following layout test is failing on all platforms.
webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html
Probable cause:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/62
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/66
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dana Jansens
Committed r131346: <http://trac.webkit.org/changeset/131346>
Dana Jansens
It sounds like it just needs a rebaseline to me, but I'm not exactly sure what may be important here.
Raymond Toy
(In reply to comment #2)
> It sounds like it just needs a rebaseline to me, but I'm not exactly sure what may be important here.
I took a quick look at the vbr-70kbps-44khz test. The data is exactly identical except the new version as added exactly one extra sample. The expected wav file has 15434 samples, and the new actual wav file has 15435 samples.
I'm also getting a failure (locally on my Linux box) with webaudio/codec-tests/mp3/128kbps-44khz.html. In this case, the files are exactly identical, except the expected file has 1105 extra (zero) samples at the end.
It looks like a recent ffmpeg update has changed this.
Raymond Toy
dalecurtis@ says this was broken in http://codereview.chromium.org/11137005/ and Chris has a fix for this forthcoming. Assigning to Chris.
Chris Rogers
I just re-baselined Mac/Win and took out the expected failure -- I'll re-baseline Linux with garden-o-matic when it shows up.
http://trac.webkit.org/changeset/131361
Dana Jansens
This has started failing in linux now, shall I rebaseline?
Chris Rogers
(In reply to comment #6)
> This has started failing in linux now, shall I rebaseline?
Sorry, Dana, I just did:
http://trac.webkit.org/changeset/131376
Let me know if there are any other failures...
thanks!
Dana Jansens
Thanks very much!
Dana Jansens
Hm, I am seeing this test failing again on ToT linux and mac
http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29/builds/39795/steps/layout-test/logs/stdio
http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/26186/steps/layout-test/logs/stdio
Dana Jansens
Marked as failing again
Committed r131383: <http://trac.webkit.org/changeset/131383>