Bug 99348

Summary: Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96804    
Attachments:
Description Flags
Patch
none
Patch for landing tony: commit-queue+

Tony Chang
Reported 2012-10-15 12:13:41 PDT
Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
Attachments
Patch (5.17 KB, patch)
2012-10-15 12:17 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.40 KB, patch)
2012-10-15 13:15 PDT, Tony Chang 		tony: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-10-15 12:17:55 PDT
Created attachment 168752 [details] Patch
Tony Chang
Comment 2 2012-10-15 12:19:45 PDT
Last one. After this, I should be able to clean up a bunch of code that saves the oldHeight, calls updateLogicalHeight, then restores the oldHeight.
Ojan Vafai
Comment 3 2012-10-15 12:24:34 PDT
Comment on attachment 168752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168752&action=review > Source/WebCore/rendering/RenderMultiColumnSet.cpp:69 > void RenderMultiColumnSet::updateLogicalHeight() > { > // Make sure our column height is up to date. FIXME maybe? To point out that this is the last method to be removed in order to make updateLogicalHeight non-virtual?
Tony Chang
Comment 4 2012-10-15 13:15:32 PDT
Created attachment 168768 [details] Patch for landing
Tony Chang
Comment 5 2012-10-15 13:54:45 PDT
Committed r131351: <http://trac.webkit.org/changeset/131351>
Note You need to log in before you can comment on or make changes to this bug.