Bug 99342

Summary: [CSS Exclusions] Handle special case "empty" shapes
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mihnea, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98548    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2012-10-15 11:17:55 PDT
The following special case shapes will be considered "empty" in the sense that ExclusionShape::getIncludedIntervals() and ExclusionShape::getExcludedIntervals() will always return empty lists of intervals: rectangles of zero width or height, circles with 0 radius, ellipses with 0 radiusX or radiusY, polygons with less than 3 vertices. Note that this isn't an exhaustive list of special cases. Still remaining: polygons with less than three vertices that are not coincident or colinear, rectangles whose corner radiusX is greater than the rectangle's width/2, rectangles whose corner radiusY is greater than the rectangle's height/2, scenarios where shape-padding and shape-padding exceeds the shape's interior space.
Attachments
Patch (11.91 KB, patch)
2012-10-15 15:53 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2012-10-15 15:35:04 PDT
Fixing bug https://bugs.webkit.org/show_bug.cgi?id=99343, which adds support for spanning colinear vertices, will correct one of the special "empty" cases not covered here.
Hans Muller
Comment 2 2012-10-15 15:53:05 PDT
Created attachment 168794 [details] Patch
WebKit Review Bot
Comment 3 2012-10-18 10:08:46 PDT
Comment on attachment 168794 [details] Patch Clearing flags on attachment: 168794 Committed r131766: <http://trac.webkit.org/changeset/131766>
WebKit Review Bot
Comment 4 2012-10-18 10:08:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.