Bug 99339

Summary: Make RenderTable columns() and columnPositions() return a const reference
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: TablesAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed change. Added more constness and a getter. none

Description Julien Chaffraix 2012-10-15 10:57:05 PDT 
The 2 functions currently return a mutable Vector reference. Only FixedTableLayout and AutoTableLayout are expected to change the values, yet most of the code is allowed to. The easy fix is to add a setter as needed so that unintended modifications are caught by the compiler.

Patch forthcoming.
Comment 1 Julien Chaffraix 2012-10-15 11:09:48 PDT 
Created attachment 168743 [details]
Proposed change. Added more constness and a getter.
Comment 2 WebKit Review Bot 2012-10-15 14:52:25 PDT 
Comment on attachment 168743 [details]
Proposed change. Added more constness and a getter.

Clearing flags on attachment: 168743

Committed r131366: <http://trac.webkit.org/changeset/131366>
Comment 3 WebKit Review Bot 2012-10-15 14:52:28 PDT 
All reviewed patches have been landed.  Closing bug.