Bug 99317

Summary: [WK2] Provide WKURL API for resolving the relative URL with the given base URL
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit2Assignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, kenneth, mitz, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 42674    
Attachments:
Description Flags
patch
kenneth: review-, kenneth: commit-queue-
patch v2 none

Mikhail Pozdnyakov
Reported 2012-10-15 06:13:17 PDT
WKURL API resolving the relative URL with the given base URL would be very useful in many use cases, one of them is finding absolute URL for WKPage if only relative URL is given (see https://bug-42674-attachments.webkit.org/attachment.cgi?id=168455 for bug42674)
Attachments
patch (3.24 KB, patch)
2012-10-15 06:32 PDT, Mikhail Pozdnyakov 		kenneth: review-
kenneth: commit-queue-
DetailsFormatted DiffDiff
patch v2 (6.28 KB, patch)
2012-10-16 02:26 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-10-15 06:32:39 PDT
Created attachment 168701 [details] patch
mitz
Comment 2 2012-10-15 08:31:34 PDT
No API test?
Kenneth Rohde Christiansen
Comment 3 2012-10-15 08:38:54 PDT
Comment on attachment 168701 [details] patch Oops right, API tests should be added.
Mikhail Pozdnyakov
Comment 4 2012-10-16 01:42:33 PDT
Seems we do not have tests for WKURL API at all.. but I can add..
Mikhail Pozdnyakov
Comment 5 2012-10-16 02:26:13 PDT
Created attachment 168897 [details] patch v2 Added test.
WebKit Review Bot
Comment 6 2012-10-16 03:16:55 PDT
Comment on attachment 168897 [details] patch v2 Clearing flags on attachment: 168897 Committed r131437: <http://trac.webkit.org/changeset/131437>
WebKit Review Bot
Comment 7 2012-10-16 03:16:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.