Bug 99303

Summary: [Qt][WK2] Buildfix for newer Qt5
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: hausmann, ossy
Priority: P1 Keywords: Qt, QtTriaged
Version: 420+   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-10-15 02:27:42 PDT
d4d81fe68aa7d2b2a89ae5e049dd630e0da77651 in qtbase ( https://codereview.qt-project.org/#change,35807 ) removed handleSynchronous* functions, so we need a buildfix for WebKit trunk with updating Qt5 hash. Patch is coming soon.
Attachments
Patch (1.42 KB, patch)
2012-10-15 02:29 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-10-15 02:29:22 PDT
Created attachment 168655 [details] Patch
Csaba Osztrogonác
Comment 2 2012-10-15 02:30:33 PDT
Comment on attachment 168655 [details] Patch cq-, because we should land it with updating Qt5 on the bots.
Simon Hausmann
Comment 3 2012-10-15 03:25:39 PDT
(In reply to comment #2) > (From update of attachment 168655 [details]) > cq-, because we should land it with updating Qt5 on the bots. I suppose we could also land it earlier? The EWS indicates that it should be a source compatible change.
Csaba Osztrogonác
Comment 4 2012-10-15 03:29:07 PDT
Comment on attachment 168655 [details] Patch Cool, let's land it now.
Csaba Osztrogonác
Comment 5 2012-10-15 03:37:25 PDT
Comment on attachment 168655 [details] Patch Clearing flags on attachment: 168655 Committed r131294: <http://trac.webkit.org/changeset/131294>
Csaba Osztrogonác
Comment 6 2012-10-15 03:37:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.