Bug 99302

Summary: [BlackBerry] replace BlackBerry::Platform::log() with BBLOG()
Product: WebKit Reporter: Jonathan Dong <jonathan.dong.webkit>
Component: WebKit BlackBerryAssignee: Jonathan Dong <jonathan.dong.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, dino, eric.carlson, feature-media-reviews, mifenton, noam, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch yong.li.webkit: review+

Jonathan Dong
Reported 2012-10-15 01:42:25 PDT
RIM PR: 210884 BBLOG() is natively defined as a no-op in release mode, so replace BlackBerry::Platform::log() with BBLOG() will save a function call in release mode.
Attachments
Patch (42.01 KB, patch)
2012-10-15 01:52 PDT, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Patch (1.69 KB, patch)
2012-10-16 08:29 PDT, Rob Buis 		yong.li.webkit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Dong
Comment 1 2012-10-15 01:52:47 PDT
Created attachment 168649 [details] Patch
Rob Buis
Comment 2 2012-10-15 06:44:40 PDT
Comment on attachment 168649 [details] Patch LGTM.
Charles Wei
Comment 3 2012-10-15 07:42:29 PDT
Comment on attachment 168649 [details] Patch Commit
WebKit Review Bot
Comment 4 2012-10-15 12:35:22 PDT
Comment on attachment 168649 [details] Patch Clearing flags on attachment: 168649 Committed r131335: <http://trac.webkit.org/changeset/131335>
WebKit Review Bot
Comment 5 2012-10-15 12:35:26 PDT
All reviewed patches have been landed. Closing bug.
Rob Buis
Comment 6 2012-10-16 08:29:41 PDT
Reopening to attach new patch.
Rob Buis
Comment 7 2012-10-16 08:29:44 PDT
Created attachment 168953 [details] Patch
Yong Li
Comment 8 2012-10-16 10:37:23 PDT
Comment on attachment 168953 [details] Patch !NDEBUG should be !defined(NDEBUG)
Rob Buis
Comment 9 2012-10-16 11:04:16 PDT
Committed r131473: <http://trac.webkit.org/changeset/131473>
Note You need to log in before you can comment on or make changes to this bug.