Bug 99291 – Input elements with multiple fields UI should set appropriate direction for browser locale automatically

• Component: Forms
• Status: RESOLVED FIXED

[Kent Tamura]

If the page is written in English (dir=ltr) but the browser locale is Arabic (RTL), input[type=date] should be laid out as dir=rtl because its content is for Arabic.

[Kent Tamura]

Created attachment 168627 [details]
Patch

[Kent Tamura]

Comment on attachment 168627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168627&action=review

> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp:276
> +    AtomicString direction = element()->localizer().isRTL() ? AtomicString("rtl", AtomicString::ConstructFromLiteral) : AtomicString("ltr", AtomicString::ConstructFromLiteral);

Note:
If we wrote AtomicString(...isRTL() ? "rtl" : "ltr", AtomicString::ConstructFromLiteral), VC++ couldn't compile it.

[Kentaro Hara]

Comment on attachment 168627 [details]
Patch

LGTM, but I'd like to delegate the review to morrita-san.

[Hajime Morrita]

Comment on attachment 168627 [details]
Patch

What about other @types?

[Kent Tamura]

(In reply to comment #4)
> (From update of attachment 168627 [details])
> What about other @types?

Good point.  This change affects date, datetime, datetime-local, month, time, and week types with multiple fields UI. However some types have no layout tests yet.

[WebKit Review Bot]

Comment on attachment 168627 [details]
Patch

Rejecting attachment 168627 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html
platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl.html
Full output: http://queues.webkit.org/results/14293803

[WebKit Review Bot]

Comment on attachment 168627 [details]
Patch

Attachment 168627 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14290816

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html
platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl.html

[Kent Tamura]

(In reply to comment #6)
> (From update of attachment 168627 [details])
> Rejecting attachment 168627 [details] from commit-queue.
> 
> New failing tests:
> platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html
> platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl.html

I should have added them to TestExpectations as expected failures.

[Kent Tamura]

Committed r131389: <http://trac.webkit.org/changeset/131389>