Bug 99270

Summary: REGRESSION(126886): Fat binary builds don't know how to handle architecture variants to which the LLInt is agnostic
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ddkilzer, ggaren, mark.lam, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 90098    
Bug Blocks:    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2012-10-14 13:05:34 PDT
This comes up with ARMv7s, where the C++ toolchain handles it as a separate architecture and may end up compiling the code in a substantially different way, while the LLInt doesn't care. The fix for https://bugs.webkit.org/show_bug.cgi?id=90098 causes the offlineasm's knowledge of ARMv7s to be dropped, since it assumes that if the offsets are the same then the configuration is the same. That's just plain wrong, since it's the configuration index (identifying the combination of settings flags) that should be uniq'd, not the offsets.
Attachments
the patch (1.90 KB, patch)
2012-10-14 13:11 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-10-14 13:11:05 PDT
Created attachment 168588 [details] the patch
Geoffrey Garen
Comment 2 2012-10-14 19:08:08 PDT
Comment on attachment 168588 [details] the patch r=me
Filip Pizlo
Comment 3 2012-10-14 19:33:25 PDT
Landed in http://trac.webkit.org/changeset/131287
Note You need to log in before you can comment on or make changes to this bug.