Bug 99215 – WebAudioBus needs support for resizing bus to a smaller size

• Component: New Bugs
• Status: RESOLVED FIXED

[Chris Rogers]

WebAudioBus needs support for resizing bus to a smaller size

[Chris Rogers]

Created attachment 168503 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Kenneth Russell]

Comment on attachment 168503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168503&action=review

> Source/Platform/chromium/public/WebAudioBus.h:54
> +    WEBKIT_EXPORT void resize(size_t newLength);

Others responsible for the design of the WebKit API should comment on this, but if this restriction is always going to apply, then this method should be called something more descriptive, like "resizeSmaller".

[Chris Rogers]

Created attachment 168505 [details]
Patch

[Kenneth Russell]

Comment on attachment 168505 [details]
Patch

Thanks. This looks good to me but please regenerate the ChangeLogs after the method renaming.

[Chris Rogers]

Created attachment 168507 [details]
Patch

[Chris Rogers]

(In reply to comment #5)
> (From update of attachment 168505 [details])
> Thanks. This looks good to me but please regenerate the ChangeLogs after the method renaming.

Thanks, fixed to resizeSmaller() and also re-generated ChangeLogs

[Kenneth Russell]

Comment on attachment 168507 [details]
Patch

This LGTM. One of the owners of the WebKit API should review it.

[WebKit Review Bot]

Comment on attachment 168507 [details]
Patch

Clearing flags on attachment: 168507

Committed r131262: <http://trac.webkit.org/changeset/131262>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.