Bug 99214

Summary: Teach GeneratorGObject about [ImplementedAs] extended attribute in functions
Product: WebKit Reporter: Pablo Flouret <pf>
Component: Tools / TestsAssignee: Pablo Flouret <pf>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, simonjam, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
haraken: review+, haraken: commit-queue-
Patch for landing none

Description Pablo Flouret 2012-10-12 15:50:50 PDT 
Looks like, coincidentally, all functions declaring [ImplementedAs] were skipped so this never manifested itself, until bug 99116 came around.
Comment 1 Pablo Flouret 2012-10-12 15:56:16 PDT 
Created attachment 168502 [details]
Patch
Comment 2 Kentaro Hara 2012-10-12 16:33:05 PDT 
Comment on attachment 168502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168502&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:979
> +    my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementedAs"} || $function->signature->name;

Nit: You can use $functionSigName instead of $function->signature->name. Or you can remove $functionSigName since it is not used so much.
Comment 3 Pablo Flouret 2012-10-12 16:40:08 PDT 
Created attachment 168511 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-10-12 17:56:49 PDT 
Comment on attachment 168511 [details]
Patch for landing

Clearing flags on attachment: 168511

Committed r131242: <http://trac.webkit.org/changeset/131242>