Bug 99207

Summary: truncated-direct-png-image.html should not be a reftest
Product: WebKit Reporter: Nick Carter <nick>
Component: Tools / TestsAssignee: Nick Carter <nick>
Status: UNCONFIRMED    
Severity: Normal CC: ahmad.saleem792, enne, hclam, jamesr, jchaffraix, nick, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=266184
Bug Depends on: 98456    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Nick Carter
Reported 2012-10-12 14:05:17 PDT
Introduced in bug 98456, truncated-direct-png-image.html was introduced as a reftest, but it doesn't need to be. As a result it failed on mac (and has been suppressed).
Attachments
Patch (4.68 KB, patch)
2012-10-12 14:23 PDT, Nick Carter 		no flags
DetailsFormatted DiffDiff
Patch (4.77 KB, patch)
2012-10-18 15:54 PDT, Nick Carter 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nick Carter
Comment 1 2012-10-12 14:23:48 PDT
Created attachment 168482 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-10-12 14:26:21 PDT
You should set the review flag if you want this reviewed.
Eric Seidel (no email)
Comment 3 2012-10-15 12:54:08 PDT
Comment on attachment 168482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168482&action=review > LayoutTests/compositing/images/truncated-direct-png-image.html:21 > + document.getElementById('layers').innerText = window.internals.layerTreeAsText(document); textContent is the more modern innerText equivalent. :) > LayoutTests/compositing/images/truncated-direct-png-image.html:32 > +The layer tree goes here in DRT. Maybe this should say FAIL in it, as it would be a failure if the JS didn't run.
Nick Carter
Comment 4 2012-10-18 15:54:07 PDT
Created attachment 169494 [details] Patch
Nick Carter
Comment 5 2012-10-18 15:54:57 PDT
(In reply to comment #3) > (From update of attachment 168482 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168482&action=review > > > LayoutTests/compositing/images/truncated-direct-png-image.html:21 > > + document.getElementById('layers').innerText = window.internals.layerTreeAsText(document); > > textContent is the more modern innerText equivalent. :) Fixed. > > > LayoutTests/compositing/images/truncated-direct-png-image.html:32 > > +The layer tree goes here in DRT. > > Maybe this should say FAIL in it, as it would be a failure if the JS didn't run. Fixed -- the "layer tree goes here" text now gets added in dynamically in the non-DRT case.
Julien Chaffraix
Comment 6 2012-10-31 09:43:06 PDT
Comment on attachment 169494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169494&action=review Nick, none of the patches you posted run on the EWS as the Mac's TestExpectations didn't apply properly. Could you post a patch against WebKit trunk that would apply cleanly? This would give the CC'ed reviewers more confidence in your change. I cannot comment on the change as I don't know window.internals.layerTreeAsText output enough. > LayoutTests/compositing/images/truncated-direct-png-image.html:1 > <html> Usually we put a DOCTYPE to test to avoid having them run in quirks mode (something most people don't want).
Ahmad Saleem
Comment 7 2024-04-27 17:20:46 PDT
We still have platform expectation but only for WK1: https://searchfox.org/wubkat/rev/c1fefa0bb16a18b82461ac3111b56f3395e7a1b7/LayoutTests/platform/mac-wk1/TestExpectations#2729 @Simon - should we need to tackle this?
Note You need to log in before you can comment on or make changes to this bug.