Bug 99204

Summary: ScrollingStateNodes should keep track of their IDs
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, jamesr, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Beth Dakin
Reported 2012-10-12 13:36:18 PDT
There is a HashMap in ScrollingCoordinatorMac that maps ScrollingNodeIDs to ScrollingStateNodes. The nodes themselves should keep track of this ID. Then the id can be used to make sure ScrollingStateNodes remove themselves from the HashMap when they are destroyed, and it will also be useful for associating ScrollingStateNodes with ScrollingTreeNodes over on the scrolling thread.
Attachments
Patch (7.08 KB, patch)
2012-10-12 13:40 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch (7.14 KB, patch)
2012-10-12 13:46 PDT, Beth Dakin 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-10-12 13:40:08 PDT
Created attachment 168473 [details] Patch
WebKit Review Bot
Comment 2 2012-10-12 13:42:32 PDT
Attachment 168473 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/scrolling/ScrollingStateNode.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 3 2012-10-12 13:46:57 PDT
Created attachment 168474 [details] Patch
Beth Dakin
Comment 4 2012-10-12 13:50:52 PDT
Thanks, Simon! Committed change: http://trac.webkit.org/changeset/131221
Note You need to log in before you can comment on or make changes to this bug.