Bug 99203

Summary:

Move QDataStream functions into HistoryItemQt.cpp

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, benjamin, cmarcelo, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

99210

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	kling: review+

Anders Carlsson

Reported 2012-10-12 13:34:35 PDT

Move QDataStream functions into HistoryItemQt.cpp

Attachments
Patch (8.97 KB, patch) 2012-10-12 13:38 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (9.48 KB, patch) 2012-10-12 14:01 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (9.02 KB, patch) 2012-10-12 16:50 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (8.59 KB, patch) 2012-10-12 17:55 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (8.61 KB, patch) 2012-10-12 18:24 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (9.67 KB, patch) 2012-10-14 16:12 PDT, Anders Carlsson	kling: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2012-10-12 13:38:12 PDT

Created attachment 168472 [details] Patch

Andreas Kling

Comment 2 2012-10-12 13:42:11 PDT

Comment on attachment 168472 [details] Patch Fair enough, assuming EWS approves.

Early Warning System Bot

Comment 3 2012-10-12 13:53:48 PDT

Comment on attachment 168472 [details] Patch Attachment 168472 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14272217

Early Warning System Bot

Comment 4 2012-10-12 13:59:40 PDT

Comment on attachment 168472 [details] Patch Attachment 168472 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14266428

Anders Carlsson

Comment 5 2012-10-12 14:01:34 PDT

Created attachment 168476 [details] Patch

WebKit Review Bot

Comment 6 2012-10-12 14:04:41 PDT

Attachment 168476 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/jsc.cpp', u'Source/W..." exit_code: 1 Source/JavaScriptCore/jsc.cpp:77: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 7 2012-10-12 14:18:46 PDT

Comment on attachment 168476 [details] Patch r=http://i.imgur.com/qUUgc.jpg

Early Warning System Bot

Comment 8 2012-10-12 14:18:49 PDT

Comment on attachment 168476 [details] Patch Attachment 168476 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14293006

Anders Carlsson

Comment 9 2012-10-12 14:19:28 PDT

Qt EWS is showing some super weird errors. I'm going to land temporarily and see if the bots show the same error.

Early Warning System Bot

Comment 10 2012-10-12 14:23:19 PDT

Comment on attachment 168476 [details] Patch Attachment 168476 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14300005