Summary: | Setup basic NetworkProcess messaging and initialization | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, ap, mjs, sam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 98537 | ||||||||||
Attachments: |
|
Description
Brady Eidson
2012-10-12 12:49:43 PDT
Created attachment 168463 [details]
Patch v1
Created attachment 168467 [details]
Patch v2
Dunno why that didn't apply... fresh rebase and new patch, let's try again.
Created attachment 168469 [details]
Patch v3 - Now with binary correctness?
Attachment 168469 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 168469 [details] Patch v3 - Now with binary correctness? Attachment 168469 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14254997 (In reply to comment #5) > (From update of attachment 168469 [details]) > Attachment 168469 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/14254997 9>..\WebProcess\WebPage\WebPage.cpp(2649) : error C2661: 'Messages::WebPageProxy::DidChangeScrollOffsetPinningForMainFrame::DidChangeScrollOffsetPinningForMainFrame' : no overloaded function takes 4 arguments 9>..\WebProcess\WebPage\WebPage.cpp(2649) : error C2780: 'bool CoreIPC::MessageSender<T>::send(const U &,uint64_t)' : expects 2 arguments - 1 provided 9> with 9> [ 9> T=WebKit::WebPage 9> ] 9> c:\cygwin\home\buildbot\WebKit\Source\WebKit2\Platform\CoreIPC\MessageSender.h(41) : see declaration of 'CoreIPC::MessageSender<T>::send' 9> with 9> [ 9> T=WebKit::WebPage 9> ] This is not related to this patch... EWS-fail? (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 168469 [details] [details]) > > Attachment 168469 [details] [details] did not pass win-ews (win): > > Output: http://queues.webkit.org/results/14254997 > > 9>..\WebProcess\WebPage\WebPage.cpp(2649) : error C2661: 'Messages::WebPageProxy::DidChangeScrollOffsetPinningForMainFrame::DidChangeScrollOffsetPinningForMainFrame' : no overloaded function takes 4 arguments > 9>..\WebProcess\WebPage\WebPage.cpp(2649) : error C2780: 'bool CoreIPC::MessageSender<T>::send(const U &,uint64_t)' : expects 2 arguments - 1 provided > 9> with > 9> [ > 9> T=WebKit::WebPage > 9> ] > 9> c:\cygwin\home\buildbot\WebKit\Source\WebKit2\Platform\CoreIPC\MessageSender.h(41) : see declaration of 'CoreIPC::MessageSender<T>::send' > 9> with > 9> [ > 9> T=WebKit::WebPage > 9> ] > > This is not related to this patch... EWS-fail? Yup, EWS-fail: 8>Generating message receiver for WebIconDatabaseProxy... 8>Generating message receiver for WebInspector... 8>/bin/sh: fork: retry: Resource temporarily unavailable 8>/bin/sh: fork: retry: Resource temporarily unavailable 8>/bin/sh: fork: retry: Resource temporarily unavailable 8>/bin/sh: fork: retry: Resource temporarily unavailable 8>/bin/sh: fork: Resource temporarily unavailable 8>make: *** [WebInspectorMessages.h] Error 254 8>NMAKE : fatal error U1077: 'bash' : return code '0x2' http://trac.webkit.org/changeset/131235 (Weird that git/svn thought I copied a header into 4 new files... oh well) |