Bug 99197

Summary: I pity da foo' who's converting numbers to strings
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, barraclough, darin, eric, fpizlo, haraken, japhet, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99191    
Attachments:
Description Flags
Patch barraclough: review+

Geoffrey Garen
Reported 2012-10-12 12:19:54 PDT
I pity da foo' who's converting numbers to strings
Attachments
Patch (4.10 KB, patch)
2012-10-12 12:22 PDT, Geoffrey Garen 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-10-12 12:21:47 PDT
So the commit message for this will just be a quickmeme link?
Geoffrey Garen
Comment 2 2012-10-12 12:22:55 PDT
Created attachment 168462 [details] Patch
Gavin Barraclough
Comment 3 2012-10-12 12:29:59 PDT
Comment on attachment 168462 [details] Patch I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion?
Geoffrey Garen
Comment 4 2012-10-12 15:46:12 PDT
> I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion? Darin mentioned this, too. Let's drive this based on how common that scenario is.
Geoffrey Garen
Comment 5 2012-10-13 09:51:22 PDT
(Side note: it's entirely possible that, if we did the research to implement canGetItemsForIndex(), we would discover that it's a no-op that always returns false.)
Geoffrey Garen
Comment 6 2012-10-13 09:51:52 PDT
Committed: <http://trac.webkit.org/changeset/131258>.
Note You need to log in before you can comment on or make changes to this bug.