Bug 99197

Summary:

I pity da foo' who's converting numbers to strings

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, barraclough, darin, eric, fpizlo, haraken, japhet, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

99191

Attachments:

Description	Flags
Patch	barraclough: review+

Description Geoffrey Garen 2012-10-12 12:19:54 PDT

I pity da foo' who's converting numbers to strings

Comment 1 Filip Pizlo 2012-10-12 12:21:47 PDT

So the commit message for this will just be a quickmeme link?

Comment 2 Geoffrey Garen 2012-10-12 12:22:55 PDT

Created attachment 168462 [details]
Patch

Comment 3 Gavin Barraclough 2012-10-12 12:29:59 PDT

Comment on attachment 168462 [details]
Patch

I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion?

Comment 4 Geoffrey Garen 2012-10-12 15:46:12 PDT

> I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion?

Darin mentioned this, too. Let's drive this based on how common that scenario is.

Comment 5 Geoffrey Garen 2012-10-13 09:51:22 PDT

(Side note: it's entirely possible that, if we did the research to implement canGetItemsForIndex(), we would discover that it's a no-op that always returns false.)

Comment 6 Geoffrey Garen 2012-10-13 09:51:52 PDT

Committed: <http://trac.webkit.org/changeset/131258>.