Bug 99190

Summary: Update method signature for platformCALayerShowRepaintCounter in MediaPlayerPlayerPrivateAVFoundation's LayerClient class.
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
none
patch simon.fraser: review+

Description Roger Fong 2012-10-12 11:01:46 PDT 
LayerClient's base class (PlatformCALayerClient) method signature for abstract method platformCALayerShowRepaintCounter was updated in http://trac.webkit.org/changeset/130676 so it needs to be changed in LayerClient as well.
Comment 1 Roger Fong 2012-10-12 11:02:58 PDT 
Created attachment 168446 [details]
patch
Comment 2 WebKit Review Bot 2012-10-12 11:04:51 PDT 
Attachment 168446 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2012-10-12 11:05:16 PDT 
Why didn't this break the build?
Comment 4 Roger Fong 2012-10-12 11:10:15 PDT 
AVCF is disabled on OpenSource
Comment 5 Roger Fong 2012-10-12 11:16:35 PDT 
Created attachment 168450 [details]
patch
Comment 6 Simon Fraser (smfr) 2012-10-12 11:17:44 PDT 
Comment on attachment 168450 [details]
patch

We should really make  platformCALayerClient non-pure to avoid all these overrides.
Comment 7 Roger Fong 2012-10-12 12:02:03 PDT 
http://trac.webkit.org/changeset/131206