Bug 99190 - Update method signature for platformCALayerShowRepaintCounter in MediaPlayerPlayerPrivateAVFoundation's LayerClient class.
Summary: Update method signature for platformCALayerShowRepaintCounter in MediaPlayerP...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-10-12 11:01 PDT by Roger Fong
Modified: 2012-10-12 12:02 PDT (History)
4 users (show)

See Also:

patch (1.99 KB, patch)
2012-10-12 11:02 PDT, Roger Fong
no flags Details | Formatted Diff | Diff
patch (1.99 KB, patch)
2012-10-12 11:16 PDT, Roger Fong
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2012-10-12 11:01:46 PDT
LayerClient's base class (PlatformCALayerClient) method signature for abstract method platformCALayerShowRepaintCounter was updated in http://trac.webkit.org/changeset/130676 so it needs to be changed in LayerClient as well.
Comment 1 Roger Fong 2012-10-12 11:02:58 PDT
Created attachment 168446 [details]
Comment 2 WebKit Review Bot 2012-10-12 11:04:51 PDT
Attachment 168446 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2012-10-12 11:05:16 PDT
Why didn't this break the build?
Comment 4 Roger Fong 2012-10-12 11:10:15 PDT
AVCF is disabled on OpenSource
Comment 5 Roger Fong 2012-10-12 11:16:35 PDT
Created attachment 168450 [details]
Comment 6 Simon Fraser (smfr) 2012-10-12 11:17:44 PDT
Comment on attachment 168450 [details]

We should really make  platformCALayerClient non-pure to avoid all these overrides.
Comment 7 Roger Fong 2012-10-12 12:02:03 PDT