Bug 99170

Summary: Web Inspector: [Styles] !important priority not honored inside the same declaration
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+, webkit.review.bot: commit-queue-

Description Alexander Pavlov (apavlov) 2012-10-12 06:05:09 PDT
The Styles pane displaying

div {
    height: 30px !important;
    height: 20px;
}

shows the first !important property as overridden, even though it takes precedence over the second one.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=131749
Comment 1 Alexander Pavlov (apavlov) 2012-10-12 07:18:19 PDT
Created attachment 168417 [details]
Patch
Comment 2 Yury Semikhatsky 2012-10-12 07:37:28 PDT
Comment on attachment 168417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168417&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:542
> +                                shouldInactivate = true;

shouldInactivate -> shouldInactivatePrevious
Comment 3 WebKit Review Bot 2012-10-12 08:05:15 PDT
Comment on attachment 168417 [details]
Patch

Attachment 168417 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14266337

New failing tests:
inspector/styles/styles-overriden-properties.html
inspector/styles/styles-new-API.html
Comment 4 Alexander Pavlov (apavlov) 2012-10-12 08:18:24 PDT
Committed r131187: <http://trac.webkit.org/changeset/131187>