Bug 99125

Summary: Stop using deprecatedSend and deprecatedSendSync for sending messages to the UI process
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: REOPENED    
Severity: Normal CC: ap, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99144    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Anders Carlsson
Reported 2012-10-11 18:49:00 PDT
Stop using deprecatedSend and deprecatedSendSync for sending messages to the UI process
Attachments
Patch (7.88 KB, patch)
2012-10-11 18:51 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-11 18:51:47 PDT
Created attachment 168333 [details] Patch
Andreas Kling
Comment 2 2012-10-11 18:54:53 PDT
Comment on attachment 168333 [details] Patch luks gud andrs.
Anders Carlsson
Comment 3 2012-10-11 18:55:51 PDT
Committed r131121: <http://trac.webkit.org/changeset/131121>
WebKit Review Bot
Comment 4 2012-10-12 00:18:40 PDT
Re-opened since this is blocked by bug 99144
Csaba Osztrogonác
Comment 5 2012-10-12 00:23:11 PDT
(In reply to comment #4) > Re-opened since this is blocked by bug 99144 It was rolled out, because it made all tests timeout on all WK2 bots. details: - http://build.webkit.org/builders/Apple%20Lion%20Release%20WK2%20%28Tests%29/builds/4153 - http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/9667
Alexey Proskuryakov
Comment 6 2012-10-13 12:37:44 PDT
Comment on attachment 168333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168333&action=review > Source/WebKit2/UIProcess/WebProcessProxy.cpp:632 > +void WebProcessProxy::postMessage(const CoreIPC::DataReference& messageData) This looks confusing. Bug title is about sending messages to UI process, but this code sends messages in the other direction.
Anders Carlsson
Comment 7 2012-10-14 17:32:51 PDT
(In reply to comment #6) > (From update of attachment 168333 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168333&action=review > > > Source/WebKit2/UIProcess/WebProcessProxy.cpp:632 > > +void WebProcessProxy::postMessage(const CoreIPC::DataReference& messageData) > > This looks confusing. Bug title is about sending messages to UI process, but this code sends messages in the other direction. Nope. It's receiving a posted message but I agree that the message name is misleading.
Note You need to log in before you can comment on or make changes to this bug.