Bug 99125 - Stop using deprecatedSend and deprecatedSendSync for sending messages to the UI process
Summary: Stop using deprecatedSend and deprecatedSendSync for sending messages to the ...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 99144
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-11 18:49 PDT by Anders Carlsson
Modified: 2012-10-14 17:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.88 KB, patch)
2012-10-11 18:51 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-10-11 18:49:00 PDT 
Stop using deprecatedSend and deprecatedSendSync for sending messages to the UI process
Comment 1 Anders Carlsson 2012-10-11 18:51:47 PDT 
Created attachment 168333 [details]
Patch
Comment 2 Andreas Kling 2012-10-11 18:54:53 PDT 
Comment on attachment 168333 [details]
Patch

luks gud andrs.
Comment 3 Anders Carlsson 2012-10-11 18:55:51 PDT 
Committed r131121: <http://trac.webkit.org/changeset/131121>
Comment 4 WebKit Review Bot 2012-10-12 00:18:40 PDT 
Re-opened since this is blocked by bug 99144
Comment 5 Csaba Osztrogonác 2012-10-12 00:23:11 PDT 
(In reply to comment #4)
> Re-opened since this is blocked by bug 99144

It was rolled out, because it made all tests timeout on all WK2 bots.
details:
- http://build.webkit.org/builders/Apple%20Lion%20Release%20WK2%20%28Tests%29/builds/4153
- http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/9667
Comment 6 Alexey Proskuryakov 2012-10-13 12:37:44 PDT 
Comment on attachment 168333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168333&action=review

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:632
> +void WebProcessProxy::postMessage(const CoreIPC::DataReference& messageData)

This looks confusing. Bug title is about sending messages to UI process, but this code sends messages in the other direction.
Comment 7 Anders Carlsson 2012-10-14 17:32:51 PDT 
(In reply to comment #6)
> (From update of attachment 168333 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168333&action=review
> 
> > Source/WebKit2/UIProcess/WebProcessProxy.cpp:632
> > +void WebProcessProxy::postMessage(const CoreIPC::DataReference& messageData)
> 
> This looks confusing. Bug title is about sending messages to UI process, but this code sends messages in the other direction.

Nope. It's receiving a posted message but I agree that the message name is misleading.