Bug 99012

Summary: [WebKit IDL] move extended attributes to left of interface, exception...
Product: WebKit Reporter: Takashi Sakamoto <tasak>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, dino, eric.carlson, feature-media-reviews, fmalita, gyuyoung.kim, haraken, japhet, macpherson, menard, mifenton, ojan, pdr, schenney, tkent, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98980    
Attachments:
Description Flags
Patch none

Takashi Sakamoto
Reported 2012-10-11 01:14:01 PDT
WebIDL spec, http://www.w3.org/TR/WebIDL/#idl-grammar, says: [1] Definitions -> ExtendedAttributeList Definition Definitions [2] Definition -> CallbackOrInterface | Partial | Dictionary | Exception | Enum | Typedef | ImplementsStatement However, current WebKit IDL grammar is different from the above, e.g. interface [ JSGenerateToNativeObject, JSInlineGetOwnPropertySlot ] Element : Node { ... ExtendedAttributeList is placed at the right of "interface". So move extended attributes in idl files to correct position.
Attachments
Patch (521.05 KB, patch)
2012-10-12 04:18 PDT, Takashi Sakamoto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Sakamoto
Comment 1 2012-10-12 04:18:47 PDT
Created attachment 168390 [details] Patch
Kentaro Hara
Comment 2 2012-10-12 04:27:33 PDT
Comment on attachment 168390 [details] Patch Great patch. Let's remove the old syntax from IDLParser.pm in a follow-up patch.
WebKit Review Bot
Comment 3 2012-10-12 04:45:09 PDT
Comment on attachment 168390 [details] Patch Clearing flags on attachment: 168390 Committed r131172: <http://trac.webkit.org/changeset/131172>
WebKit Review Bot
Comment 4 2012-10-12 04:45:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.