Summary: | [Chromium] Calendar picker: should use consistent Localizer object | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | haraken, morrita, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kent Tamura
2012-10-10 20:28:18 PDT
Created attachment 168133 [details]
Patch
Comment on attachment 168133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168133&action=review Looks reasonable > Source/WebKit/chromium/ChangeLog:15 > + environment; e.g. Month labels in a calendar picker were numeric. This > + patch fixes it, and this is covered by > + fast/forms/date/calendar-picker-appearance.html. No change in the test result? Or you might want to add a new test that covers this change. Comment on attachment 168133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168133&action=review >> Source/WebKit/chromium/ChangeLog:15 >> + fast/forms/date/calendar-picker-appearance.html. > > No change in the test result? Or you might want to add a new test that covers this change. The test is already marked as failure in TestExpectations. I won't add image results to this patch because I don't have handy Linux (ICU) environment. Comment on attachment 168133 [details]
Patch
Makes sense.
FYI. See Linux results: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=calendar-picker-appearance.html Comment on attachment 168133 [details] Patch Clearing flags on attachment: 168133 Committed r131011: <http://trac.webkit.org/changeset/131011> All reviewed patches have been landed. Closing bug. |