Bug 98975

Summary:

Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore Misc.

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cmarcelo, dimisec, eric, gyuyoung.kim, macpherson, menard, mifenton, rakuco, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	abarth: review+, webkit.review.bot: commit-queue-

Description Jian Li 2012-10-10 17:27:39 PDT

Need to rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION.

Comment 1 Jian Li 2012-10-10 17:44:10 PDT

Created attachment 168107 [details]
Proposed Patch

Comment 2 WebKit Review Bot 2012-10-16 15:04:28 PDT

Comment on attachment 168107 [details]
Proposed Patch

Rejecting attachment 168107 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
file Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/Configurations/FeatureDefines.xcconfig
Hunk #2 FAILED at 140.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/Configurations/FeatureDefines.xcconfig.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14389329

Comment 3 Jian Li 2012-10-16 17:42:12 PDT

Committed as http://trac.webkit.org/changeset/131532.

Comment 4 Dmitri S 2013-04-15 01:01:16 PDT

(typo in the bug Description - to ENABLE_DRAGGBALE_REGION, should be DRAGGABLE - correct in the code)