Bug 98975 - Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION
Summary: Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 17:27 PDT by Jian Li
Modified: 2013-04-15 01:01 PDT (History)
11 users (show)

See Also:


Attachments
Proposed Patch (52.36 KB, patch)
2012-10-10 17:44 PDT, Jian Li
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2012-10-10 17:27:39 PDT
Need to rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION.
Comment 1 Jian Li 2012-10-10 17:44:10 PDT
Created attachment 168107 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2012-10-16 15:04:28 PDT
Comment on attachment 168107 [details]
Proposed Patch

Rejecting attachment 168107 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
file Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/Configurations/FeatureDefines.xcconfig
Hunk #2 FAILED at 140.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/Configurations/FeatureDefines.xcconfig.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14389329
Comment 3 Jian Li 2012-10-16 17:42:12 PDT
Committed as http://trac.webkit.org/changeset/131532.
Comment 4 Dmitri S 2013-04-15 01:01:16 PDT
(typo in the bug Description - to ENABLE_DRAGGBALE_REGION, should be DRAGGABLE - correct in the code)