Bug 98971

Summary: Disallow full screen mode keyboard access by default.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: mjs, sam, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jer Noble
Reported 2012-10-10 17:05:07 PDT
Disallow full screen mode keyboard access by default.
Attachments
Patch (5.25 KB, patch)
2012-10-10 17:10 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (5.36 KB, patch)
2012-10-10 17:12 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-10-10 17:09:24 PDT
Clients can override the default behavior (through the WebView delegate in WebKit, and through the InjectedBundlePageFullScreenClient interface in WebKit2). But by default, keyboard access should be denied.
Jer Noble
Comment 2 2012-10-10 17:09:39 PDT
<rdar://problem/12474226>
Jer Noble
Comment 3 2012-10-10 17:10:46 PDT
Created attachment 168102 [details] Patch
Jer Noble
Comment 4 2012-10-10 17:12:56 PDT
Created attachment 168103 [details] Patch Added radar link to ChangeLogs
Maciej Stachowiak
Comment 5 2012-10-10 19:14:08 PDT
Does this change the behavior for other ports?
Jer Noble
Comment 6 2012-10-10 21:17:07 PDT
(In reply to comment #5) > Does this change the behavior for other ports? Yes it does. Ports can override this default, but only Chromium does.
Maciej Stachowiak
Comment 7 2012-10-10 22:39:47 PDT
(In reply to comment #6) > (In reply to comment #5) > > Does this change the behavior for other ports? > > Yes it does. Ports can override this default, but only Chromium does. OK. It's likely that other non-Chromium ports only got the keyboard access support by accident, then.
WebKit Review Bot
Comment 8 2012-10-10 23:40:00 PDT
Comment on attachment 168103 [details] Patch Clearing flags on attachment: 168103 Committed r131018: <http://trac.webkit.org/changeset/131018>
WebKit Review Bot
Comment 9 2012-10-10 23:40:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.