Summary: | [texmap] logic error in BitmapTextureGL::updateContents | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | arno. <a.renevier> | ||||||
Component: | Layout and Rendering | Assignee: | arno. <a.renevier> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jturcotte, noam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
arno.
2012-10-10 16:53:38 PDT
Created attachment 168098 [details]
Patch
patch proposal
Attachment 168098 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 168101 [details]
Patch
amended patch
Comment on attachment 168101 [details] Patch Rejecting attachment 168101 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e-webkit line 164. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14257387 (In reply to comment #4) > (From update of attachment 168101 [details]) > Rejecting attachment 168101 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > e-webkit line 164. > > Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 > BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult. > > When you have resolved this problem run "git rebase --continue". > If you would prefer to skip this patch, instead run "git rebase --skip". > To restore the original branch and stop rebasing run "git rebase --abort". > > rebase refs/remotes/origin/master: command returned error: 1 > > Died at Tools/Scripts/update-webkit line 164. > > Full output: http://queues.webkit.org/results/14257387 I don't really understand why the patch could not be applied Comment on attachment 168101 [details]
Patch
Not sure either, the error seems unrelated.
Trying again.
Comment on attachment 168101 [details] Patch Clearing flags on attachment: 168101 Committed r131078: <http://trac.webkit.org/changeset/131078> All reviewed patches have been landed. Closing bug. |