Bug 98968

Summary: REGRESSION: Unable to scroll with trackpad on some websites after r130783
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, jamesr, simon.fraser, thorton, tonikitoo, webkit.review.bot
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Beth Dakin
Reported 2012-10-10 16:40:54 PDT
http://trac.webkit.org/changeset/130783 broke scrolling on some internal Apple websites. The bug also affects bugs.webkit.org for me sometimes. Unfortunately, I do not have a reduced test case because the bug fails to reproduce when you save sites locally. <rdar://problem/12471825> Patch forthcoming.
Attachments
Patch (6.48 KB, patch)
2012-10-10 16:53 PDT, Beth Dakin 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-10-10 16:53:14 PDT
Created attachment 168095 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-10-10 18:00:27 PDT
Comment on attachment 168095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168095&action=review > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:85 > + m_changedProperties = ViewportRect | ContentsSize | NonFastScrollableRegion | WheelEventHandlerCount > + | ShouldUpdateScrollLayerPositionOnMainThread | HorizontalScrollElasticity | VerticalScrollElasticity > + | HasEnabledHorizontalScrollbar | HasEnabledVerticalScrollbar | HorizontalScrollbarMode > + | VerticalScrollbarMode | ScrollOrigin | RequestedScrollPosition; Would be nicer if the enum had an 'All' value that was 0xFF or the OR of all the values.
Beth Dakin
Comment 3 2012-10-10 18:25:11 PDT
Thanks Simon! I added an All value. http://trac.webkit.org/changeset/130989
Note You need to log in before you can comment on or make changes to this bug.