Bug 98959

Summary: check-layout.js should always dumpAsText
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+, tony: commit-queue-

Ojan Vafai
Reported 2012-10-10 15:28:10 PDT
check-layout.js should always dumpAsText
Attachments
Patch (43.50 KB, patch)
2012-10-10 15:30 PDT, Ojan Vafai 		tony: review+
tony: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-10-10 15:30:52 PDT
Created attachment 168079 [details] Patch
Tony Chang
Comment 2 2012-10-10 16:36:49 PDT
Comment on attachment 168079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168079&action=review > LayoutTests/css3/flexbox/flex-item-child-overflow.html:-27 > -<div data-expected-height=0 class="flexbox"> > - <div data-expected-height=0> > - <div data-offset-y=0 data-expected-height=20></div> I would convert this to not be a ref-test since we do want to verify that the parent boxes have 0 height.
Ojan Vafai
Comment 3 2012-10-10 16:42:28 PDT
Committed r130979: <http://trac.webkit.org/changeset/130979>
Note You need to log in before you can comment on or make changes to this bug.