Bug 98923

Summary:

Web Inspector: Enabling experiments tab in WebKit nightly.

Product:

WebKit

Reporter:

Mihai Balan <mibalan>

Component:

Web Inspector (Deprecated)

Assignee:

Mihai Balan <mibalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, WebkitBugTracker, webkit.review.bot, yurys

Priority:

Keywords:

AdobeTracked

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch for always enabling the experiments tab.	pfeldman: review-
Patch for enabling the experiments tab in WebKit nightly	none

Mihai Balan

Reported 2012-10-10 10:09:49 PDT

As per the discussion at http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html all experimental features will be enabled in Safari's Web Inspector.

Attachments
Patch for always enabling the experiments tab. (1.41 KB, patch) 2012-10-11 07:24 PDT, Mihai Balan	pfeldman: review-	Details Formatted Diff Diff
Patch for enabling the experiments tab in WebKit nightly (3.11 KB, patch) 2012-10-11 09:07 PDT, Mihai Balan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mihai Balan

Comment 1 2012-10-10 10:13:59 PDT

(In reply to comment #0) > As per the discussion at http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html all experimental features will be enabled in Safari's Web Inspector. The initial wording is actually wrong. This patch is about enabling the experimental tab in WebKit nightly (not having it depend on a runtime flag - as is the case in Chromium)

Mihai Balan

Comment 2 2012-10-11 07:24:31 PDT

Created attachment 168224 [details] Patch for always enabling the experiments tab.

Alexander Pavlov (apavlov)

Comment 3 2012-10-11 07:27:30 PDT

Comment on attachment 168224 [details] Patch for always enabling the experiments tab. View in context: https://bugs.webkit.org/attachment.cgi?id=168224&action=review So, what about non-nightlies? Do all parties agree that we should enable experiments in all possible cases? > Source/WebCore/inspector/front-end/Settings.js:220 > + // to enable it at runtime Lost closing parenthesis :)

Mihai Balan

Comment 4 2012-10-11 07:32:54 PDT

(In reply to comment #3) > (From update of attachment 168224 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168224&action=review > > So, what about non-nightlies? Do all parties agree that we should enable experiments in all possible cases? > This is my understanding from the discussion on webkit-dev [1] and the one on IRC today. [1] http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html

Pavel Feldman

Comment 5 2012-10-11 08:51:48 PDT

Comment on attachment 168224 [details] Patch for always enabling the experiments tab. This will also enable experiments in Chrome. You should instead add Preferences.experimentsEnabled and make it "true" in WebCore/inspector/front-end/Settings.js and "false" in WebKit/chromium/src/js/DevTools.js. This check will become Preferences.experimentsEnabled || "experiments" in WebInspector.queryParamsObject. I think it is fine to enable experiments on stable versions given that Safari ships its proprietary front-end now.

Mihai Balan

Comment 6 2012-10-11 09:07:43 PDT

Created attachment 168238 [details] Patch for enabling the experiments tab in WebKit nightly

WebKit Review Bot

Comment 7 2012-10-11 09:29:49 PDT

Comment on attachment 168238 [details] Patch for enabling the experiments tab in WebKit nightly Clearing flags on attachment: 168238 Committed r131071: <http://trac.webkit.org/changeset/131071>

WebKit Review Bot

Comment 8 2012-10-11 09:29:52 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.