Bug 98883

Summary: [EFL][WK2] Add toolbar buttons to MiniBrowser
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98748    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Screenshot
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2012-10-10 03:55:49 PDT 
It would be nice to add a "back" button to MiniBrowser.
Comment 1 Chris Dumez 2012-10-10 10:47:51 PDT 
Created attachment 168031 [details]
Patch
Comment 2 Chris Dumez 2012-10-10 10:48:18 PDT 
Created attachment 168032 [details]
Screenshot
Comment 3 Chris Dumez 2012-10-10 11:01:48 PDT 
Created attachment 168037 [details]
Patch

Warning fix.
Comment 4 Chris Dumez 2012-10-10 11:08:08 PDT 
Created attachment 168038 [details]
Patch

Fixed a few typos.
Comment 5 Chris Dumez 2012-10-10 11:12:36 PDT 
Created attachment 168040 [details]
Patch
Comment 6 Kenneth Rohde Christiansen 2012-10-10 14:35:09 PDT 
Comment on attachment 168040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168040&action=review

> Source/WebKit2/ChangeLog:8
> +        Add "back,forward,list,changed" signal on the Ewk_View

Now we are talking!

> Tools/MiniBrowser/efl/main.c:217
> +    /* Update navigation buttons state */

EFL supports // comments now :-) Apparently Rasterman accepted that!
Comment 7 WebKit Review Bot 2012-10-10 16:36:17 PDT 
Comment on attachment 168040 [details]
Patch

Clearing flags on attachment: 168040

Committed r130978: <http://trac.webkit.org/changeset/130978>
Comment 8 WebKit Review Bot 2012-10-10 16:36:21 PDT 
All reviewed patches have been landed.  Closing bug.