Bug 98883

Summary: [EFL][WK2] Add toolbar buttons to MiniBrowser
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98748    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Screenshot
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2012-10-10 03:55:49 PDT
It would be nice to add a "back" button to MiniBrowser.
Attachments
Patch (13.79 KB, patch)
2012-10-10 10:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Screenshot (43.29 KB, image/png)
2012-10-10 10:48 PDT, Chris Dumez 		no flags
Details
Patch (13.79 KB, patch)
2012-10-10 11:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (13.79 KB, patch)
2012-10-10 11:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (13.80 KB, patch)
2012-10-10 11:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-10 10:47:51 PDT
Created attachment 168031 [details] Patch
Chris Dumez
Comment 2 2012-10-10 10:48:18 PDT
Created attachment 168032 [details] Screenshot
Chris Dumez
Comment 3 2012-10-10 11:01:48 PDT
Created attachment 168037 [details] Patch Warning fix.
Chris Dumez
Comment 4 2012-10-10 11:08:08 PDT
Created attachment 168038 [details] Patch Fixed a few typos.
Chris Dumez
Comment 5 2012-10-10 11:12:36 PDT
Created attachment 168040 [details] Patch
Kenneth Rohde Christiansen
Comment 6 2012-10-10 14:35:09 PDT
Comment on attachment 168040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168040&action=review > Source/WebKit2/ChangeLog:8 > + Add "back,forward,list,changed" signal on the Ewk_View Now we are talking! > Tools/MiniBrowser/efl/main.c:217 > + /* Update navigation buttons state */ EFL supports // comments now :-) Apparently Rasterman accepted that!
WebKit Review Bot
Comment 7 2012-10-10 16:36:17 PDT
Comment on attachment 168040 [details] Patch Clearing flags on attachment: 168040 Committed r130978: <http://trac.webkit.org/changeset/130978>
WebKit Review Bot
Comment 8 2012-10-10 16:36:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.