Bug 98880

Summary: [Qt]QtTestBrowser should have default url(google.com) when no command line args
Product: WebKit Reporter: Vivek Galatage <vivekgalatage>
Component: New BugsAssignee: Vivek Galatage <vivekgalatage>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Vivek Galatage
Reported 2012-10-10 03:39:01 PDT
[Qt]QtTestBrowser should have default url(google.com) when no command line args
Attachments
Patch (1.30 KB, patch)
2012-10-10 04:00 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-10-10 04:00:15 PDT
Created attachment 167974 [details] Patch
Vivek Galatage
Comment 2 2012-10-10 04:18:37 PDT
Ossy: Since today, I have shifted to using git for webkit development. Hence wanted to see how the webkit-patch script would work with git. Hence created and submitted this patch. And thank you for seconding the idea of using the url as default.
WebKit Review Bot
Comment 3 2012-10-10 04:51:50 PDT
Comment on attachment 167974 [details] Patch Rejecting attachment 167974 [details] from commit-queue. New failing tests: fast/frames/frame-limit.html Full output: http://queues.webkit.org/results/14249340
WebKit Review Bot
Comment 4 2012-10-10 05:33:26 PDT
Comment on attachment 167974 [details] Patch Clearing flags on attachment: 167974 Committed r130890: <http://trac.webkit.org/changeset/130890>
WebKit Review Bot
Comment 5 2012-10-10 05:33:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.