Bug 98877

Summary: FontVerticalDataCache should allow zero as a key value
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: TextAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kenichi Ishibashi
Reported 2012-10-10 01:10:00 PDT
It seems that FontPlatformDataHarfBuzz::uniqueID() can be zero for valid instance. Since FontPlatformDataHarfBuzz::uniqueID() is used for a key of FontVerticalDataCache in some ports (chromium linux, android, blackberry), the cache should accept zero as a key value.
Attachments
Patch (2.80 KB, patch)
2012-10-10 01:15 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-10-10 01:15:59 PDT
Created attachment 167954 [details] Patch
Kenichi Ishibashi
Comment 2 2012-10-10 01:29:13 PDT
Hi Tony, Could you take a look?
Kenichi Ishibashi
Comment 3 2012-10-10 15:11:03 PDT
Comment on attachment 167954 [details] Patch Thanks!
WebKit Review Bot
Comment 4 2012-10-10 15:17:16 PDT
Comment on attachment 167954 [details] Patch Clearing flags on attachment: 167954 Committed r130968: <http://trac.webkit.org/changeset/130968>
WebKit Review Bot
Comment 5 2012-10-10 15:17:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.