Summary: | REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | Tools / Tests | Assignee: | Sergio Villar Senin <svillar> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gustavo, mrobinson, philn, spenap, svillar, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-10-09 23:24:39 PDT
I can think of two ways to fix this: either generating the gresource in a different location where it gets zipped, or adding a new exception in the built-product-archive. The current "neededDirectories" are "Programs", ".libs", "Libraries" and "TestNetscapePlugin", and I don't think the gresource bundle fits in any of them. On the other hand, it doesn't seem right to add DerivedSources/WebKit2 as a "neededDirectory", so maybe we could generate the bundle into some new location and add that new location as an exception. (In reply to comment #1) > I can think of two ways to fix this: either generating the gresource in a different location where it gets zipped, or adding a new exception in the built-product-archive. > So I agree with this. I think the best option is to generate the resource under DerivedSources/WebKit2/resources and then just add it to the list of dirs to export. Created attachment 171059 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 171059 [details]
Patch
Hrm. I don't think that DerivedSources is the right place to generate this the GResource file anyway. It should probably be generated into Programs/resources. DerivedSources is a place to put pre-compilation generated source code, not build products.
Created attachment 171317 [details]
Patch
Comment on attachment 171317 [details]
Patch
Great! Thanks.
Comment on attachment 171317 [details] Patch Clearing flags on attachment: 171317 Committed r132870: <http://trac.webkit.org/changeset/132870> All reviewed patches have been landed. Closing bug. Thank you guys! |