| Summary: | [BlackBerry] Define WTF_USE_EXPORT_MACROS in cmake rather than Platform.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yong Li <yong.li.webkit> | ||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, gyuyoung.kim, laszlo.gombos, rakuco, rwlbuis, tonikitoo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yong Li
2012-10-09 13:18:53 PDT
Created attachment 167842 [details]
the patch
As the WebKit project does not have a common build-system, I find it more readable and manageable to keep these build rules in C/C++ (shared) code rather than moving them to a port specific build file. Having said that it is probably time to break up Platform.h into smaller files (e.g. config-blackberry.h). Related discussion at bug 97250. (In reply to comment #2) > As the WebKit project does not have a common build-system, I find it more readable and manageable to keep these build rules in C/C++ (shared) code rather than moving them to a port specific build file. > > Having said that it is probably time to break up Platform.h into smaller files (e.g. config-blackberry.h). > > Related discussion at bug 97250. Thanks for the info. For some stable macros (using JIT or some features), probably it is better to define them in the .h file. But I feel this symbol exporting stuff should better be decided by the build system Comment on attachment 167842 [details]
the patch
Looks good.
Comment on attachment 167842 [details] the patch Clearing flags on attachment: 167842 Committed r130909: <http://trac.webkit.org/changeset/130909> All reviewed patches have been landed. Closing bug. Oops, just found a typo in the title... |