Bug 98819

Summary: [BlackBerry] Define WTF_USE_EXPORT_MACROS in cmake rather than Platform.h
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, gyuyoung.kim, laszlo.gombos, rakuco, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch none

Yong Li
Reported 2012-10-09 13:18:53 PDT
Define WTF_USE_EXTRA_MACROS in cmake rather than Platform.h, and make it depend on SHARED_CORE
Attachments
the patch (2.27 KB, patch)
2012-10-09 13:55 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-10-09 13:55:14 PDT
Created attachment 167842 [details] the patch
Laszlo Gombos
Comment 2 2012-10-09 18:29:19 PDT
As the WebKit project does not have a common build-system, I find it more readable and manageable to keep these build rules in C/C++ (shared) code rather than moving them to a port specific build file. Having said that it is probably time to break up Platform.h into smaller files (e.g. config-blackberry.h). Related discussion at bug 97250.
Yong Li
Comment 3 2012-10-10 07:38:25 PDT
(In reply to comment #2) > As the WebKit project does not have a common build-system, I find it more readable and manageable to keep these build rules in C/C++ (shared) code rather than moving them to a port specific build file. > > Having said that it is probably time to break up Platform.h into smaller files (e.g. config-blackberry.h). > > Related discussion at bug 97250. Thanks for the info. For some stable macros (using JIT or some features), probably it is better to define them in the .h file. But I feel this symbol exporting stuff should better be decided by the build system
Rob Buis
Comment 4 2012-10-10 08:23:40 PDT
Comment on attachment 167842 [details] the patch Looks good.
WebKit Review Bot
Comment 5 2012-10-10 08:48:41 PDT
Comment on attachment 167842 [details] the patch Clearing flags on attachment: 167842 Committed r130909: <http://trac.webkit.org/changeset/130909>
WebKit Review Bot
Comment 6 2012-10-10 08:48:45 PDT
All reviewed patches have been landed. Closing bug.
Yong Li
Comment 7 2012-10-10 11:12:52 PDT
Oops, just found a typo in the title...
Note You need to log in before you can comment on or make changes to this bug.