Bug 98805

Summary: Add tests to testapi for null OpaqueJSStrings
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 98300    
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2012-10-09 11:36:54 PDT
There isn't sufficient testing for the handling of null OpaqueJSStrings. This is evident from the changes to OpaqueJSString in r130344 from https://bugs.webkit.org/show_bug.cgi?id=98300 and its follow-ons.
Attachments
Patch (3.07 KB, patch)
2012-10-09 12:49 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-10-09 12:49:53 PDT
Created attachment 167824 [details] Patch
Geoffrey Garen
Comment 2 2012-10-09 17:52:10 PDT
Comment on attachment 167824 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-10-09 18:18:53 PDT
Comment on attachment 167824 [details] Patch Clearing flags on attachment: 167824 Committed r130832: <http://trac.webkit.org/changeset/130832>
WebKit Review Bot
Comment 4 2012-10-09 18:18:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.