Bug 98790 – [EFL][WK2] Add APIs to get/set the DNS prefetching

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Jinwoo Song]

Add ewk_settings_enable_DNS_prefetching_get/set APIs to WebKit2/Efl.

[Jinwoo Song]

Created attachment 167778 [details]
Patch

[Laszlo Gombos]

Comment on attachment 167778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review

LGTM.

> Source/WebKit2/ChangeLog:8
> +        Added setting APIs for DNS prefetching and a unit test.

Added -> Add.

[Chris Dumez]

Comment on attachment 167778 [details]
Patch

Sorry but this is missing unit tests. We should not land new APIs without unit tests.

[Chris Dumez]

(In reply to comment #3)
> (From update of attachment 167778 [details])
> Sorry but this is missing unit tests. We should not land new APIs without unit tests.

arg... never mind me. There are unit tests :)
Go ahead then.

[Gyuyoung Kim]

Comment on attachment 167778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:206
> + * @param settings settings object to get DNS prefetching.

We don't use '.' at @param.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:154
> +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_TRUE));

We decided to use standard boolean in test case.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:157
> +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_FALSE));

ditto.

[Jinwoo Song]

(In reply to comment #2)
> (From update of attachment 167778 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review
> 
> LGTM.
> 
> > Source/WebKit2/ChangeLog:8
> > +        Added setting APIs for DNS prefetching and a unit test.
> 
> Added -> Add.

Fixed.

[Jinwoo Song]

(In reply to comment #5)
> (From update of attachment 167778 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167778&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:206
> > + * @param settings settings object to get DNS prefetching.
> 
> We don't use '.' at @param.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:154
> > +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_TRUE));
> 
> We decided to use standard boolean in test case.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:157
> > +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_FALSE));
> 
> ditto.

Fixed.

[Jinwoo Song]

Created attachment 167965 [details]
Patch

[WebKit Review Bot]

Comment on attachment 167965 [details]
Patch

Clearing flags on attachment: 167965

Committed r130882: <http://trac.webkit.org/changeset/130882>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Raphael Kubo da Costa (:rakuco)]

Sorry for chiming in late. Isn't it better to use `dns' instead of `DNS'? We normally don't uppercase abbreviations in our APIs.

[Jinwoo Song]

(In reply to comment #11)
> Sorry for chiming in late. Isn't it better to use `dns' instead of `DNS'? We normally don't uppercase abbreviations in our APIs.

I didn't catch that. Then I'll change it in https://bugs.webkit.org/show_bug.cgi?id=98793. Thanks. :)