Bug 98757 – [EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Raphael Kubo da Costa (:rakuco)]

[EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 167755 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 167755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376
> +    priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible);

hide -> view is visible?

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #2)
> (From update of attachment 167755 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376
> > +    priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible);
> 
> hide -> view is visible?

-ENOPARSE :-)

There's no WebPageProxy::ViewIsHidden; all the machinery to change the state is inside viewStateDidChange itself, which takes care of setting the visibility to hidden or visibile depending on what WebPageProxy::viewIsVisible() returns.

[Kenneth Rohde Christiansen]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 167755 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review
> > 
> > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376
> > > +    priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible);
> > 
> > hide -> view is visible?
> 
> -ENOPARSE :-)
> 
> There's no WebPageProxy::ViewIsHidden; all the machinery to change the state is inside viewStateDidChange itself, which takes care of setting the visibility to hidden or visibile depending on what WebPageProxy::viewIsVisible() returns.

Oh my, needs a comment anyway!

[Raphael Kubo da Costa (:rakuco)]

Created attachment 167757 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Committed r130764: <http://trac.webkit.org/changeset/130764>